Closed
Bug 1125095
Opened 9 years ago
Closed 9 years ago
[Task Manager] Update colour of 'x' and bar so it doesn't feel disabled
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S6 (20feb)
People
(Reporter: epang, Assigned: sfoster)
References
Details
(Whiteboard: [systemsfe])
Attachments
(3 files, 1 obsolete file)
Update the asset for the close icon in the task manager (the tab view can stay as is). Currently the colour makes the icon look disabled. Spec: https://mozilla.box.com/s/j5qmx25wtan556ujs69x Assets: https://mozilla.box.com/s/ln1lmq2doah3jd096jal
Assignee | ||
Comment 1•9 years ago
|
||
This is the task manager & tab view side by side with my patch applied. It has the new 'close' button asset(s) and the darker color button tray in task manager.
Attachment #8561677 -
Flags: ui-review?(epang)
Comment 2•9 years ago
|
||
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8561677 [details] task-manager-polish.png Hey Sam, it's looking good! But I didn't realize that the tab manager was using an outdated close icon. Can you update with the one here and flag me for review again? https://mozilla.box.com/s/eegvz3lv3e9zd6gmcy546sshw4vot73t Thanks!
Attachment #8561677 -
Flags: ui-review?(epang) → ui-review-
Assignee | ||
Comment 4•9 years ago
|
||
Updated with the close icons from https://mozilla.box.com/s/eegvz3lv3e9zd6gmcy546sshw4vot73t
Attachment #8561677 -
Attachment is obsolete: true
Attachment #8562934 -
Flags: ui-review?(epang)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8562934 [details]
task-manager-polish.png
looks good, thanks for updating the asset. R+
Attachment #8562934 -
Flags: ui-review?(epang) → ui-review+
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8561679 [details] [review] [PullReq] sfoster:task-manager-polish-bug-1125095 to mozilla-b2g:master Polish
Attachment #8561679 -
Flags: review?(etienne)
Comment 7•9 years ago
|
||
Comment on attachment 8561679 [details] [review] [PullReq] sfoster:task-manager-polish-bug-1125095 to mozilla-b2g:master sorry for the delay, lgtm!
Attachment #8561679 -
Flags: review?(etienne) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a0bfc4ca03b5b11aaf1e58e9161fe54a1805e475
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 9•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/1a3474a2c99d46d8cce406d841f3edc8e9a79e43
Comment 10•9 years ago
|
||
This bug has been verified as "pass" on latest Nightly build of Flame v2.2&master by the STR in Comment 0. Actual results: On task manager, the new 'Close' icon and bar won't let user feel it is disabled, and they shows clearly. See attachment: verified_2.2&master.png Reproduce rate: 0/10 Device: Flame v2.2 (Verified) Build ID 20150705162505 Gaia Revision ea11f422b687a982f0a961c9aea7858066561707 Gaia Date 2015-07-02 23:37:50 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0214b4c1ea0 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150705.200108 Firmware Date Sun Jul 5 20:01:20 EDT 2015 Bootloader L1TC000118D0 Device: Flame master (Verified) Build ID 20150705160206 Gaia Revision dc6c18c0dea7af3c40bfff86c530fd877d899dc4 Gaia Date 2015-07-04 01:35:20 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/136c41fca853 Gecko Version 42.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150705.193055 Firmware Date Sun Jul 5 19:31:07 EDT 2015 Bootloader L1TC000118D0
Comment 11•9 years ago
|
||
Updated•9 years ago
|
QA Whiteboard: [MGSEI-Triage+]
You need to log in
before you can comment on or make changes to this bug.
Description
•